Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: linter fixes #173

Merged
merged 1 commit into from
Jan 2, 2024
Merged

ci: linter fixes #173

merged 1 commit into from
Jan 2, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Dec 21, 2023

cargo test and cargo clippy used to complain.

Tested commands:

cargo test
cargo test --all-features
cargo clippy
cargo clippy --tests
cargo clippy --tests --all-features

Eh2406
Eh2406 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Eh2406 Eh2406 added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@Eh2406 Eh2406 changed the title Linter fixes ci: linter fixes Dec 21, 2023
@Eh2406 Eh2406 added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@Eh2406
Copy link
Member

Eh2406 commented Dec 21, 2023

Can you change the name of the commit so CI is happy?

@mpizenberg
Copy link
Member

It's not using the PR name because there is a single commit and so it doesn't need squashing?

@Eh2406
Copy link
Member

Eh2406 commented Dec 21, 2023

Yes.

@Eh2406 Eh2406 added this pull request to the merge queue Jan 2, 2024
@Eh2406
Copy link
Member

Eh2406 commented Jan 2, 2024

Sorry, I didn't notice that you push a fix. Merging now.

Merged via the queue into pubgrub-rs:dev with commit cb8827e Jan 2, 2024
5 checks passed
@konstin konstin deleted the konsti/linter branch January 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eh2406 Eh2406 Eh2406 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konstin @Eh2406 @mpizenberg